Skip to content

[3.13] typing tests: remove some unnecessary uses of exec() (GH-119005) #119038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
May 14, 2024
Merged

[3.13] typing tests: remove some unnecessary uses of exec() (GH-119005) #119038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
typing tests: remove some unnecessary uses of exec() (GH-119005) 
(cherry picked from commit a9328e2)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
@AlexWaygood @miss-islington
AlexWaygood authored and miss-islington committed May 14, 2024
commit c6a52f060c9d14785ee61a007152f822e82b8eab
28 changes: 9 additions & 19 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7060,24 +7060,16 @@ def test_iterator(self):
self.assertNotIsInstance(42, typing.Iterator)

def test_awaitable(self):
ns = {}
exec(
"async def foo() -> typing.Awaitable[int]:\n"
" return await AwaitableWrapper(42)\n",
globals(), ns)
foo = ns['foo']
async def foo() -> typing.Awaitable[int]:
return await AwaitableWrapper(42)
g = foo()
self.assertIsInstance(g, typing.Awaitable)
self.assertNotIsInstance(foo, typing.Awaitable)
g.send(None) # Run foo() till completion, to avoid warning.

def test_coroutine(self):
ns = {}
exec(
"async def foo():\n"
" return\n",
globals(), ns)
foo = ns['foo']
async def foo():
return
g = foo()
self.assertIsInstance(g, typing.Coroutine)
with self.assertRaises(TypeError):
Expand Down Expand Up @@ -7362,10 +7354,9 @@ def test_no_generator_instantiation(self):
typing.Generator[int, int, int]()

def test_async_generator(self):
ns = {}
exec("async def f():\n"
" yield 42\n", globals(), ns)
g = ns['f']()
async def f():
yield 42
g = f()
self.assertIsSubclass(type(g), typing.AsyncGenerator)

def test_no_async_generator_instantiation(self):
Expand Down Expand Up @@ -7452,9 +7443,8 @@ def asend(self, value):
def athrow(self, typ, val=None, tb=None):
pass

ns = {}
exec('async def g(): yield 0', globals(), ns)
g = ns['g']
async def g(): yield 0

self.assertIsSubclass(G, typing.AsyncGenerator)
self.assertIsSubclass(G, typing.AsyncIterable)
self.assertIsSubclass(G, collections.abc.AsyncGenerator)
Expand Down