Skip to content

gh-118878: Pyrepl: show completions menu below the current line #118939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 16 commits into from
Jan 21, 2025
Merged

gh-118878: Pyrepl: show completions menu below the current line #118939

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
dc98b55
gh-118877: Fix AssertionError crash in pyrepl
danielhollas May 10, 2024
eae92aa
gh-118878: pyrepl: Show completion menu below current line
danielhollas May 11, 2024
9e2170c
WIP: Add test
danielhollas May 12, 2024
da921c1
Revert "WIP: Add test"
danielhollas May 22, 2024
dd90c2e
Merge branch 'main' into pyrepl/completions-below
danielhollas May 22, 2024
4498c29
Add test
danielhollas May 22, 2024
14805a8
Fix test
danielhollas May 22, 2024
119c01d
Get rid of spurious output in test_interact.py
danielhollas May 22, 2024
c5407d5
Merge branch 'main' into pyrepl/completions-below
danielhollas May 31, 2024
af90634
Merge branch 'main' into pyrepl/completions-below
danielhollas Jun 24, 2024
d150136
Fix test
danielhollas Jun 24, 2024
f7f346a
Merge branch 'main' into pyrepl/completions-below
danielhollas Jul 14, 2024
ce0641d
Add blurb
danielhollas Jul 14, 2024
aa9a3a3
Remove test
danielhollas Jul 14, 2024
c686ce2
Merge branch 'main' into pyrepl/completions-below
danielhollas Sep 8, 2024
8feaaca
Merge branch 'main' into pyrepl/completions-below
pablogsal Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove test
  • Loading branch information
@danielhollas
danielhollas committed Jul 14, 2024
commit aa9a3a39e9f6d5a194c578fef7812516cc7120ff
27 changes: 0 additions & 27 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,33 +702,6 @@ def test_up_down_arrow_with_completion_menu(self):
# so we should end up where we were when we initiated tab completion.
output = multiline_input(reader, namespace)
self.assertEqual(output, "os.")
# TODO: The menu should be visible, but currently isn't?
# self.assertEqual(reader.cmpltn_menu_visible, True)

# TODO: This test doesn't seem to work as intended.
def test_right_down_arrows_with_completion_menu(self):
"""Right / Down arrows while the tab completion menu is displayed
should do nothing"""
code = "os.\t\t"
namespace = {"os": os}

events = itertools.chain(
code_to_events(code),
[
Event(evt="key", data="down", raw=bytearray(b"\x1bOB")),
Event(evt="key", data="right", raw=bytearray(b"\x1bOC")),
],
code_to_events("\n")
)
reader = self.prepare_reader(events, namespace=namespace)
output = multiline_input(reader, namespace)
self.assertEqual(output, "os.")
# When we press right and/or down arrow while
# the completions menu is displayed,
# the cursor should stay where it was on the line.
self.assertEqual(reader.cxy, (6, 0))
# TODO: The menu should be visible, but currently isn't?
# self.assertEqual(reader.cmpltn_menu_visible, True)

@patch("_pyrepl.readline._ReadlineWrapper.get_reader")
@patch("sys.stderr", new_callable=io.StringIO)
Expand Down