Skip to content

gh-118899: Add tests for NotImplemented attribute access #118902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 3 commits into from
May 12, 2024
Merged

gh-118899: Add tests for NotImplemented attribute access #118902

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49d3e6a
gh-118899: Add tests for `NotImplemented` attribute access
sobolevn May 10, 2024
abaff2f
Also test `...`
sobolevn May 12, 2024
8550f84
Address review
sobolevn May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Also test ...
  • Loading branch information
@sobolevn
sobolevn committed May 12, 2024
commit abaff2ff266a320821cb35ab3a177cab6670b46a
32 changes: 17 additions & 15 deletions Lib/test/test_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2138,21 +2138,23 @@ def test_bool_notimplemented(self):
with self.assertRaisesRegex(TypeError, msg):
not NotImplemented

def test_not_implemented(self):
self.assertIs(type(NotImplemented), NotImplemented.__class__)
self.assertIs(type(NotImplemented).__class__, type)

# Missing instance attributes:
with self.assertRaises(AttributeError):
NotImplemented.prop
with self.assertRaises(AttributeError):
NotImplemented.prop = 1

# Missing class attributes:
with self.assertRaises(AttributeError):
type(NotImplemented).prop
with self.assertRaises(TypeError):
type(NotImplemented).prop = 1
def test_singleton_attribute_access(self):
for singleton in (NotImplemented, Ellipsis):
with self.subTest(singleton):
self.assertIs(type(singleton), singleton.__class__)
self.assertIs(type(singleton).__class__, type)

# Missing instance attributes:
with self.assertRaises(AttributeError):
singleton.prop
with self.assertRaises(AttributeError):
singleton.prop = 1
Comment thread
sobolevn marked this conversation as resolved.

# Missing class attributes:
with self.assertRaises(AttributeError):
type(singleton).prop
with self.assertRaises(TypeError):
type(singleton).prop = 1


class TestBreakpoint(unittest.TestCase):
Expand Down