Skip to content

gh-118846: Fix free-threading test failures when run sequentially #118864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 4 commits into from
May 10, 2024
Merged

gh-118846: Fix free-threading test failures when run sequentially #118864

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
852175f
gh-118846: Fix free-threading test failures when run sequentially
colesbury May 9, 2024
923dd2d
Merge branch 'main' into gh-118846-all-tests
colesbury May 9, 2024
f469a2e
Fix test_pydoc failure
colesbury May 9, 2024
0c0c9b4
Fix test_gc when run sequentially
colesbury May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test_gc when run sequentially
  • Loading branch information
@colesbury
colesbury committed May 9, 2024
commit 0c0c9b4312e1e2668f1294cfca955355ca4788cb
8 changes: 8 additions & 0 deletions Lib/test/test_gc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,6 +1355,10 @@ def callback(ignored):
junk = []
i = 0
detector = GC_Detector()
if Py_GIL_DISABLED:
# The free-threaded build doesn't have multiple generations, so
# just trigger a GC manually.
gc.collect()
while not detector.gc_happened:
i += 1
if i > 10000:
Expand Down Expand Up @@ -1423,6 +1427,10 @@ def __del__(self):
detector = GC_Detector()
junk = []
i = 0
if Py_GIL_DISABLED:
# The free-threaded build doesn't have multiple generations, so
# just trigger a GC manually.
gc.collect()
while not detector.gc_happened:
i += 1
if i > 10000:
Expand Down