Skip to content

gh-118849: Fix "code will never be executed" warning in dictobject.c #118850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 2 commits into from
May 9, 2024
Merged

gh-118849: Fix "code will never be executed" warning in dictobject.c #118850

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02409a
gh-118849: Fix "code will never be executed" warning in `dictobject.c`
sobolevn May 9, 2024
6056023
Fix CI
sobolevn May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-118849: Fix "code will never be executed" warning in dictobject.c
  • Loading branch information
@sobolevn
sobolevn committed May 9, 2024
commit d02409a686c44cebda4d92fa222cc7437822ce04
3 changes: 1 addition & 2 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5491,10 +5491,9 @@ dictiter_iternext_threadsafe(PyDictObject *d, PyObject *self,
Py_DECREF(d);
return -1;

int res;
try_locked:
Py_BEGIN_CRITICAL_SECTION(d);
res = dictiter_iternextitem_lock_held(d, self, out_key, out_value);
int res = dictiter_iternextitem_lock_held(d, self, out_key, out_value);
Comment thread
colesbury marked this conversation as resolved.
Outdated
Py_END_CRITICAL_SECTION();
return res;
}
Expand Down