Skip to content

gh-117657: Fix QSBR race condition #118843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 14 commits into from
May 10, 2024
Merged

gh-117657: Fix QSBR race condition #118843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f3a362d
gh-117657: initialize_new_array
SonicField May 9, 2024
ec921f7
gh-118817: Fix `asyncio REPL` on Windows (#118819)
Eclips4 May 9, 2024
154a3f5
gh-117657: Acquire a critical section around `SemLock.__{enter,exit}_…
mpage May 9, 2024
a6bc4e3
gh-118773: Use language-invariant SDDL string instead of aliases for …
zooba May 9, 2024
63af4b5
gh-118849: Fix "code will never be executed" warning in `dictobject.c…
sobolevn May 9, 2024
fa80517
gh-118561: Fix crash involving list.extend in free-threaded build (#1…
colesbury May 9, 2024
e0bb384
gh-116984: Make mimalloc header includes relative to the current file…
colesbury May 9, 2024
888d3d7
gh-118846: Fix PGO tests in free-threaded build (#118862)
colesbury May 9, 2024
64a7f49
gh-117657: Replace TSAN suppresions with more specific rules (#118722)
swtaarrs May 9, 2024
bb8677d
gh-118851: Default ctx arguments to AST constructors to Load() (#118854)
JelleZijlstra May 9, 2024
9c4ae02
Revert "gh-115432: Add critical section variant that handles a NULL o…
colesbury May 9, 2024
6502eb3
Docs: fix typos in documentation (GH-118815)
xyb May 10, 2024
1dff338
Merge branch 'python:main' into main
SonicField May 10, 2024
0f901c9
gh-117657: initialize_new_array remove suppresion
SonicField May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-118846: Fix PGO tests in free-threaded build (#118862) 
Avoid immortalizing objects in tests that verify garbage collection of
classes or modules.

This fixes test_ordered_dict and test_struct.
  • Loading branch information
@colesbury @SonicField
colesbury authored and SonicField committed May 10, 2024
commit 888d3d79c9339ae93a14d804d64316ed37723f00
3 changes: 2 additions & 1 deletion Lib/test/test_ordered_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import weakref
from collections.abc import MutableMapping
from test import mapping_tests, support
from test.support import import_helper
from test.support import import_helper, suppress_immortalization


py_coll = import_helper.import_fresh_module('collections',
Expand Down Expand Up @@ -667,6 +667,7 @@ def test_dict_update(self):
dict.update(od, [('spam', 1)])
self.assertNotIn('NULL', repr(od))

@suppress_immortalization()
def test_reference_loop(self):
# Issue 25935
OrderedDict = self.OrderedDict
Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import weakref

from test import support
from test.support import import_helper
from test.support import import_helper, suppress_immortalization
from test.support.script_helper import assert_python_ok

ISBIGENDIAN = sys.byteorder == "big"
Expand Down Expand Up @@ -674,6 +674,7 @@ def __del__(self):
self.assertIn(b"Exception ignored in:", stderr)
self.assertIn(b"C.__del__", stderr)

@suppress_immortalization()
def test__struct_reference_cycle_cleaned_up(self):
# Regression test for python/cpython#94207.

Expand Down