Skip to content

[3.10] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 5 commits into from
May 24, 2024
Merged

[3.10] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118740

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1193b36
gh-118486: Support mkdir(mode=0o700) on Windows
zooba May 1, 2024
3387172
Fix CVE in docs
zooba May 7, 2024
8b2d733
Use language-invariant ACL
zooba May 9, 2024
77ede7c
gh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (GH-1…
zooba May 15, 2024
49746a0
Merge branch '3.10' into gh-118486-3.10
ambv May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CVE in docs
  • Loading branch information
@zooba
zooba authored May 7, 2024
commit 338717220588eb40dd042f55e1a92ef8acc60f76
4 changes: 2 additions & 2 deletions Doc/whatsnew/3.10.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,7 +1250,7 @@ and :data:`~os.O_NOFOLLOW_ANY` for macOS.
As of 3.10.15, :func:`os.mkdir` and :func:`os.makedirs` on Windows now support
passing a *mode* value of ``0o700`` to apply access control to the new
directory. This implicitly affects :func:`tempfile.mkdtemp` and is a
mitigation for :cve:`2024-4030`. Other values for *mode* continue to be
mitigation for CVE-2024-4030. Other values for *mode* continue to be
ignored.
(Contributed by Steve Dower in :gh:`118486`.)

Expand Down Expand Up @@ -1411,7 +1411,7 @@ tempfile

As of 3.10.15 on Windows, the default mode ``0o700`` used by
:func:`tempfile.mkdtemp` now limits access to the new directory due to
changes to :func:`os.mkdir`. This is a mitigation for :cve:`2024-4030`.
changes to :func:`os.mkdir`. This is a mitigation for CVE-2024-4030.
(Contributed by Steve Dower in :gh:`118486`.)

_thread
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Security/2024-05-01-20-57-09.gh-issue-118486.K44KJG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
:func:`os.mkdir` on Windows now accepts *mode* of ``0o700`` to restrict
the new directory to the current user. This fixes :cve:`2024-4030`
the new directory to the current user. This fixes CVE-2024-4030
affecting :func:`tempfile.mkdtemp` in scenarios where the base temporary
directory is more permissive than the default.