Skip to content

gh-116322: Enable the GIL while loading C extension modules #118560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 9 commits into from
May 7, 2024
Merged

gh-116322: Enable the GIL while loading C extension modules #118560

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e324003
Enable the GIL while loading C extension modules
swtaarrs Apr 30, 2024
3e8fee5
📜🤖 Added by blurb_it.
blurb-it[bot] May 3, 2024
637c3e5
Mark _wmi module
swtaarrs May 3, 2024
fecf4bd
Use _PyEval_IsGILEnabled() in _is_gil_enabled()
swtaarrs May 3, 2024
0fd1967
Review comments from Sam, plus some cleanup
swtaarrs May 3, 2024
ab4fe48
Merge remote-tracking branch 'upstream/main' into cpython-enable-gil
swtaarrs May 6, 2024
0271a16
Store GIL slot in cache instead of separate list, other fixes from Eric
swtaarrs May 6, 2024
2d8c2b2
Always define singlephase_global_update.md_gil to clean up callsite
swtaarrs May 6, 2024
b430f7b
Merge remote-tracking branch 'upstream/main' into cpython-enable-gil
swtaarrs May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark _wmi module
  • Loading branch information
@swtaarrs
swtaarrs committed May 3, 2024
commit 637c3e50750f65c12a41f9946a5ce64c7328af11
12 changes: 9 additions & 3 deletions PC/_wmimodule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,12 +362,18 @@ static PyMethodDef wmi_functions[] = {
{ NULL, NULL, 0, NULL }
};

static PyModuleDef_Slot wmi_slots[] = {
{Py_mod_gil, Py_MOD_GIL_NOT_USED},
{0, NULL},
};

static PyModuleDef wmi_def = {
PyModuleDef_HEAD_INIT,
"_wmi",
NULL, // doc
0, // m_size
wmi_functions
NULL, // doc
0, // m_size
wmi_functions, // m_methods
wmi_slots, // m_slots
};

extern "C" {
Expand Down