Skip to content

GH-118447: Fix handling of unreadable symlinks in os.path.realpath() #118489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 8 commits into from
May 18, 2024
Merged

GH-118447: Fix handling of unreadable symlinks in os.path.realpath() #118489

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1619428
GH-118447: Handle unreadable symlinks in `os.path.realpath()`
barneygale May 1, 2024
fc5e670
DRY
barneygale May 1, 2024
8d3fbff
Fix + NEWS
barneygale May 1, 2024
90a4fe3
Update Lib/test/test_posixpath.py
barneygale May 18, 2024
8230c3c
Merge branch 'main' into secret-symlinks
barneygale May 18, 2024
f13e494
Switch back to using `os.stat()` to raise ELOOP.
barneygale May 18, 2024
a29e836
Unused import
barneygale May 18, 2024
0af033d
Undo unnecessary changes
barneygale May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DRY
  • Loading branch information
@barneygale
barneygale committed May 1, 2024
commit fc5e670bbf55546e9b262d50d2f65d213762a799
13 changes: 1 addition & 12 deletions Lib/test/test_posixpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,19 +668,8 @@ def test_realpath_unreadable_symlink(self):
os.symlink(ABSTFN+"1", ABSTFN)
os.chmod(ABSTFN, 0o000, follow_symlinks=False)
self.assertEqual(realpath(ABSTFN), ABSTFN)
Comment thread
barneygale marked this conversation as resolved.
finally:
os.chmod(ABSTFN, 0o755, follow_symlinks=False)
os.unlink(ABSTFN)

@os_helper.skip_unless_symlink
@skip_if_ABSTFN_contains_backslash
@unittest.skipIf(os.chmod not in os.supports_follow_symlinks, "Can't set symlink permissions")
def test_realpath_unreadable_symlink_strict(self):
try:
os.symlink(ABSTFN+"1", ABSTFN)
os.chmod(ABSTFN, 0o000, follow_symlinks=False)
with self.assertRaises(PermissionError):
realpath(ABSTFN)
realpath(ABSTFN, strict=True)
finally:
os.chmod(ABSTFN, 0o755, follow_symlinks=False)
os.unlink(ABSTFN)
Expand Down