Skip to content

bpo-35984: _xxsubinterpreters: Fix memory leak in _channel_send()#11845

Merged
miss-islington merged 1 commit into
python:masterfrom
izbyshev:channel-send-leak
Feb 15, 2019
Merged

bpo-35984: _xxsubinterpreters: Fix memory leak in _channel_send()#11845
miss-islington merged 1 commit into
python:masterfrom
izbyshev:channel-send-leak

Conversation

@izbyshev

@izbyshev izbyshev commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

@vstinner

Copy link
Copy Markdown
Member

No NEWS entry needed since the fixed module is private.

@vstinner

Copy link
Copy Markdown
Member

I tested manually the change: it works as expected.

Without this change, "./python -m test -R 3:3 test__xxsubinterpreters" fails ("leaked [3, 4, 3] memory blocks, sum=10"). With this change, the test doesn't leak anymore.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants