Skip to content

[3.7] bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port (GH-11823) #11829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Feb 12, 2019
Merged

[3.7] bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port (GH-11823) #11829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/test/test_imaplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import time
import calendar
import threading
import socket

from test.support import (reap_threads, verbose, transient_internet,
run_with_tz, run_with_locale, cpython_only)
Expand Down Expand Up @@ -71,6 +72,15 @@ def test_that_Time2Internaldate_returns_a_result(self):
imaplib.Time2Internaldate(t)

def test_imap4_host_default_value(self):
# Check whether the IMAP4_PORT is truly unavailable.
with socket.socket() as s:
try:
s.connect(('', imaplib.IMAP4_PORT))
self.skipTest(
"Cannot run the test with local IMAP server running.")
except socket.error:
pass

expected_errnos = [
# This is the exception that should be raised.
errno.ECONNREFUSED,
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2019-02-12-01-33-08.bpo-35505.N9ba_K.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Make test_imap4_host_default_value independent on whether the
local IMAP server is running.