Skip to content

bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port#11823

Merged
vstinner merged 4 commits into
python:masterfrom
mcepl:35505_skip_on_listening_imap_port
Feb 12, 2019
Merged

bpo-35505: Skip test_imap4_host_default_value if localhost listens on IMAP port#11823
vstinner merged 4 commits into
python:masterfrom
mcepl:35505_skip_on_listening_imap_port

Conversation

@mcepl
Copy link
Copy Markdown
Contributor

@mcepl mcepl commented Feb 12, 2019 •
edited by bedevere-bot
Loading

test_imaplib.TestImaplib.test_imap4_host_default_value fails when run on
the computer with the local IMAP server running. This may happen for
developers, who consequently don't need to be bothered about this test
failing.

https://bugs.python.org/issue35505

@mcepl
bpo-35505: Skip test_imap4_host_default_value if localhost listens on…
96f8e44 
… IMAP port.

test_imaplib.TestImaplib.test_imap4_host_default_value fails when run on
the computer with the local IMAP server running. This may happen for
developers, who consequently don't need to be bothered about this test
failing.
@mcepl mcepl requested a review from a team as a code owner February 12, 2019 00:35
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Feb 12, 2019
eamanu
eamanu approved these changes Feb 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I don't think that is necessary a news for a new test.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Feb 12, 2019

Would it be possible to use a different port instead? Using test.support.find_unused_port() for example.

vstinner
vstinner reviewed Feb 12, 2019
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2019-02-12-01-33-08.bpo-35505.N9ba_K.rst Outdated
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Feb 12, 2019

I tested manually.

Terminal 1:

echo -n|sudo nc -l 143 -v

Terminal 2:

./python -m test -u all test_imaplib -m test_imap4_host_default_value -v

Without this change, Terminal 1 shows an incoming connection ("Ncat: Connection from ::1:35778.") and the test fails with imaplib.IMAP4.abort: socket error: EOF.

With the change: no incoming connection and the test pass as expected.

vstinner
vstinner reviewed Feb 12, 2019
View reviewed changes
Comment thread Lib/test/test_imaplib.py Outdated
Comment thread Lib/test/test_imaplib.py Outdated
Comment thread Lib/test/test_imaplib.py Outdated
vstinner
vstinner reviewed Feb 12, 2019
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2019-02-12-01-33-08.bpo-35505.N9ba_K.rst
@mcepl
Update test_imaplib according to reivew.
7489d9c 
Also, move NEWS item to right directory.
vstinner
vstinner approved these changes Feb 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vstinner
vstinner reviewed Feb 12, 2019
View reviewed changes
Comment thread Lib/test/test_imaplib.py Outdated
@vstinner vstinner merged commit 3dc67d0 into python:master Feb 12, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 12, 2019

Thanks @mcepl for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 12, 2019

GH-11829 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 12, 2019
@mcepl @miss-islington
bpo-35505: Skip test_imap4_host_default_value if localhost listens on…
3aa1fb0 
… IMAP port (pythonGH-11823)

Make test_imap4_host_default_value independent on whether the
local IMAP server is running.
(cherry picked from commit 3dc67d0)

Co-authored-by: Matěj Cepl <mcepl@cepl.eu>
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Feb 12, 2019

@mcepl: The patch doesn't apply cleanup on the 2.7 branch. Can you try to write at patch for 2.7?

@mcepl mcepl deleted the 35505_skip_on_listening_imap_port branch February 12, 2019 18:51
@mcepl
Copy link
Copy Markdown
Contributor Author

mcepl commented Feb 12, 2019

@vstinner There is nothing to port to … 2.7 just doesn't have this test case at all.

miss-islington added a commit that referenced this pull request Feb 12, 2019
@miss-islington @mcepl
bpo-35505: Skip test_imap4_host_default_value if localhost listens on…
009220e 
… IMAP port (GH-11823)

Make test_imap4_host_default_value independent on whether the
local IMAP server is running.
(cherry picked from commit 3dc67d0)

Co-authored-by: Matěj Cepl <mcepl@cepl.eu>
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Feb 12, 2019

@vstinner There is nothing to port to … 2.7 just doesn't have this test case at all.

Aha :-D Good. I close the issue in that case ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mcepl @vstinner @miss-islington @bedevere-bot @eamanu @the-knights-who-say-ni