Skip to content

gh-107674: Lazy load line number to improve performance of tracing #118127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 4 commits into from
Apr 29, 2024
+61 −19
Merged

gh-107674: Lazy load line number to improve performance of tracing #118127

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af1ed33
Lazy load f_lineno to improve performance of tracing
gaogaotiantian Apr 20, 2024
6acff3d
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 20, 2024
a6cee96
Fix the lineno cache issue
gaogaotiantian Apr 20, 2024
4fecbd4
early return if calculation fails
gaogaotiantian Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
early return if calculation fails 
Co-authored-by: Mark Shannon <mark@hotpy.org>
  • Loading branch information
@gaogaotiantian @markshannon
gaogaotiantian and markshannon authored Apr 26, 2024
commit 4fecbd46fff8cddfcec7672b7b703e957813f1cd
1 change: 1 addition & 0 deletions Objects/frameobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ PyFrame_GetLineNumber(PyFrameObject *f)
f->f_lineno = PyUnstable_InterpreterFrame_GetLine(f->f_frame);
if (f->f_lineno < 0) {
f->f_lineno = 0;
Comment thread
gaogaotiantian marked this conversation as resolved.
return -1;
}
}

Expand Down