Skip to content

gh-114053: Fix bad interaction of PEP-695, PEP-563 and get_type_hints #118009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 4 commits into from
Apr 19, 2024
Merged

gh-114053: Fix bad interaction of PEP-695, PEP-563 and get_type_hints #118009

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c76bfc0
gh-114053: Fix bad interaction of PEP-695, PEP-563 and ``get_type_hin…
AlexWaygood Apr 17, 2024
edd89d7
Docs
AlexWaygood Apr 17, 2024
3c56a61
Improve tests and add a comment
AlexWaygood Apr 18, 2024
a7f6f82
Update Doc/library/typing.rst
AlexWaygood Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Doc/library/typing.rst 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
  • Loading branch information
@AlexWaygood @JelleZijlstra
AlexWaygood and JelleZijlstra authored Apr 19, 2024
commit a7f6f82a549e796eca74055fc8d2f39393997c3b
2 changes: 1 addition & 1 deletion Doc/library/typing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3025,7 +3025,7 @@ Introspection helpers
This is often the same as ``obj.__annotations__``. In addition,
forward references encoded as string literals are handled by evaluating
them in ``globals``, ``locals`` and (where applicable)
:ref:`type parameter <annotation-scopes>` namespaces.
:ref:`type parameter <type-params>` namespaces.
For a class ``C``, return
Comment on lines +3027 to +3029
Copy link
Copy Markdown
Member Author

@AlexWaygood AlexWaygood Apr 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't usually add .. versionchanged notes for bugfixes (and I think this is a bugfix), but I could add one if we think this is a significant enough change to the function's semantics

a dictionary constructed by merging all the ``__annotations__`` along
``C.__mro__`` in reverse order.
Expand Down