Skip to content

gh-112069: Add _PySet_NextEntryRef to be thread-safe. #117990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 11 commits into from
Apr 18, 2024
Merged

gh-112069: Add _PySet_NextEntryRef to be thread-safe. #117990

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f1776aa
gh-112069: Make _PySet_NextEntry to be thread-safe.
corona10 Apr 17, 2024
4170a35
nit
corona10 Apr 17, 2024
60e8d53
WIP
corona10 Apr 17, 2024
c8b531d
nit
corona10 Apr 17, 2024
c81dd70
Update
corona10 Apr 17, 2024
0e32d1a
nit
corona10 Apr 17, 2024
fbb9964
Remove uncessary locking
corona10 Apr 17, 2024
5d57a56
fix
corona10 Apr 17, 2024
ae8f217
Address code review
corona10 Apr 18, 2024
3bd4ede
Fix refleaks
corona10 Apr 18, 2024
99fb7e6
nit
corona10 Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove uncessary locking
  • Loading branch information
@corona10
corona10 committed Apr 17, 2024
commit fbb996478e3d6d2febc4e9ff16bdf4cbe4bbd816
2 changes: 0 additions & 2 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,12 +1287,10 @@ list_extend_set(PyListObject *self, PySetObject *other)
Py_hash_t hash;
PyObject *key;
PyObject **dest = self->ob_item + m;
Py_BEGIN_CRITICAL_SECTION(other);
while (_PySet_NextEntry((PyObject *)other, &setpos, &key, &hash)) {
FT_ATOMIC_STORE_PTR_RELEASE(*dest, key);
dest++;
}
Py_END_CRITICAL_SECTION();
Py_SET_SIZE(self, m + n);
return 0;
}
Expand Down