Skip to content

Quick test to see if removing the tier2 interpreter speeds up tier1 #117908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum wants to merge 9 commits into from
Closed

Quick test to see if removing the tier2 interpreter speeds up tier1 #117908

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dba4b9b
Hard-code _Py_NOTIER2 **temporarily** until I figure out how to add a…
gvanrossum Apr 15, 2024
ada980b
Disallow JIT and NOTIER2 flags together
gvanrossum Apr 15, 2024
2794ead
If NOTIER2, don't ever call into it from bytecodes.c
gvanrossum Apr 15, 2024
aa47106
Remove tier2 interpreter if NOTIER2
gvanrossum Apr 15, 2024
2055e5f
Fix test_opt (expose _opcode.NOTIER2 and disable tests if set)
gvanrossum Apr 15, 2024
4d33fa2
Leave Windows compiler optimization on if _Py_NOTIER2 is defined
gvanrossum Apr 16, 2024
0c195cb
Fix the problem with CALL_STAT_INC (see issue)
gvanrossum Apr 16, 2024
e83be54
Support a proper ./configure option --disable-tier2
gvanrossum Apr 15, 2024
ced0ca9
Also disable updating the bitmask cache for PUP_JUMP_IF*
gvanrossum Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also disable updating the bitmask cache for PUP_JUMP_IF*
  • Loading branch information
@gvanrossum
gvanrossum committed Apr 16, 2024
commit ced0ca939c2fbd7e2f7ffe2d38ce4c2e06789084
12 changes: 12 additions & 0 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2398,18 +2398,22 @@ dummy_func(
replaced op(_POP_JUMP_IF_FALSE, (cond -- )) {
assert(PyBool_Check(cond));
int flag = Py_IsFalse(cond);
#ifndef _Py_NOTIER2
#if ENABLE_SPECIALIZATION
this_instr[1].cache = (this_instr[1].cache << 1) | flag;
#endif
#endif
JUMPBY(oparg * flag);
}

replaced op(_POP_JUMP_IF_TRUE, (cond -- )) {
assert(PyBool_Check(cond));
int flag = Py_IsTrue(cond);
#ifndef _Py_NOTIER2
#if ENABLE_SPECIALIZATION
this_instr[1].cache = (this_instr[1].cache << 1) | flag;
#endif
#endif
JUMPBY(oparg * flag);
}

Expand Down Expand Up @@ -3979,9 +3983,11 @@ dummy_func(
assert(PyBool_Check(cond));
int flag = Py_IsTrue(cond);
int offset = flag * oparg;
#ifndef _Py_NOTIER2
#if ENABLE_SPECIALIZATION
this_instr[1].cache = (this_instr[1].cache << 1) | flag;
#endif
#endif
INSTRUMENTED_JUMP(this_instr, next_instr + offset, PY_MONITORING_EVENT_BRANCH);
}

Expand All @@ -3990,9 +3996,11 @@ dummy_func(
assert(PyBool_Check(cond));
int flag = Py_IsFalse(cond);
int offset = flag * oparg;
#ifndef _Py_NOTIER2
#if ENABLE_SPECIALIZATION
this_instr[1].cache = (this_instr[1].cache << 1) | flag;
#endif
#endif
INSTRUMENTED_JUMP(this_instr, next_instr + offset, PY_MONITORING_EVENT_BRANCH);
}

Expand All @@ -4007,9 +4015,11 @@ dummy_func(
Py_DECREF(value);
offset = 0;
}
#ifndef _Py_NOTIER2
#if ENABLE_SPECIALIZATION
this_instr[1].cache = (this_instr[1].cache << 1) | flag;
#endif
#endif
INSTRUMENTED_JUMP(this_instr, next_instr + offset, PY_MONITORING_EVENT_BRANCH);
}

Expand All @@ -4024,9 +4034,11 @@ dummy_func(
Py_DECREF(value);
offset = oparg;
}
#ifndef _Py_NOTIER2
#if ENABLE_SPECIALIZATION
this_instr[1].cache = (this_instr[1].cache << 1) | !nflag;
#endif
#endif
INSTRUMENTED_JUMP(this_instr, next_instr + offset, PY_MONITORING_EVENT_BRANCH);
}

Expand Down
16 changes: 16 additions & 0 deletions Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.