bpo-35931: Gracefully handle SyntaxError in pdb debug command by blueyed · Pull Request #11782 · python/cpython

blueyed · 2019-02-07T16:03:41Z

Previously, debug print( would cause the interpreter to exit on a SyntaxError whereas print( would properly display the error and return to the pdb prompt.

This patch fixes this by pre-compiling the code before passing it to Pdb.run.

https://bugs.python.org/issue35931

On the pdb prompt `debug print(` currently crashes, but `print(` displays that there's a SyntaxError. This patch fixes this by pre-compiling the code for `Pdb.run`.

zware

Can you add a test for this? It will also need a NEWS entry (you can use https://blurb-it.herokuapp.com/ for that purpose).

blueyed · 2019-02-07T16:23:29Z

Can you add a test for this?

Done.

blueyed · 2019-02-07T17:29:37Z

+
+    def test_syntaxerror_debug(self):
+        stdout, _ = self.run_pdb_module("", "debug print(")
+        self.assertIn('(Pdb) *** SyntaxError: unexpected EOF while parsing\n(Pdb) ', stdout)


Would appreciate feedback on this.. should it be put into a single test? (mainly wanting this to be fast)
As for this change only test_syntaxerror_debug could be added also.

Also needs to be fixed for Windows to include \r / use splitlines.

Hi, yes IMO would be better add whole in a single test, because you are testing the same things.

Also needs to be fixed for Windows to include \r / use splitlines.

Currently there are problems with Azure test

because you are testing the same things.

Not really.. the test for just print( was working before this patch already (and uses another code path).

eamanu · 2019-02-08T14:08:42Z

+
+    def test_syntaxerror_debug(self):
+        stdout, _ = self.run_pdb_module("", "debug print(")
+        self.assertIn('(Pdb) *** SyntaxError: unexpected EOF while parsing\n(Pdb) ', stdout)


Hi, yes IMO would be better add whole in a single test, because you are testing the same things.

eamanu · 2019-02-08T14:10:10Z

@@ -0,0 +1 @@
+pdb: handle SyntaxError with ``debug``.


I will change for: "Add handle SyntaxError with debug on pdb" (just an opinon)

eamanu · 2019-02-08T14:14:14Z

+
+    def test_syntaxerror_debug(self):
+        stdout, _ = self.run_pdb_module("", "debug print(")
+        self.assertIn('(Pdb) *** SyntaxError: unexpected EOF while parsing\n(Pdb) ', stdout)


Also needs to be fixed for Windows to include \r / use splitlines.

Currently there are problems with Azure test

eamanu

LGMT. I test it. And work fine on Ubuntu 18

zware

LGTM.

miss-islington · 2019-02-15T20:52:53Z

@blueyed: Status check is done, and it's a success ✅ .

miss-islington · 2019-02-15T20:52:56Z

Thanks @blueyed for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

…GH-11782) Previously, `debug print(` would cause the interpreter to exit on a SyntaxError whereas `print(` would properly display the error and return to the pdb prompt. This patch fixes this by pre-compiling the code before passing it to `Pdb.run`. https://bugs.python.org/issue35931 (cherry picked from commit 4327705) Co-authored-by: Daniel Hahler <github@thequod.de>

bedevere-bot · 2019-02-15T20:53:13Z

GH-11886 is a backport of this pull request to the 3.7 branch.

Previously, `debug print(` would cause the interpreter to exit on a SyntaxError whereas `print(` would properly display the error and return to the pdb prompt. This patch fixes this by pre-compiling the code before passing it to `Pdb.run`. https://bugs.python.org/issue35931 (cherry picked from commit 4327705) Co-authored-by: Daniel Hahler <github@thequod.de>

NOTE: will be fixed in Python 3.7.3 itself (python/cpython#11782).

blueyed · 2019-02-28T18:26:38Z

Followup in #12103.

NOTE: will be fixed in Python 3.7.3 itself (python/cpython#11782).

pdb: do_debug: handle SyntaxError

128e813

On the pdb prompt `debug print(` currently crashes, but `print(` displays that there's a SyntaxError. This patch fixes this by pre-compiling the code for `Pdb.run`.

bedevere-bot added the awaiting review label Feb 7, 2019

the-knights-who-say-ni added the CLA signed label Feb 7, 2019

zware reviewed Feb 7, 2019

View reviewed changes

blurb-it Bot and others added 2 commits February 7, 2019 16:22

📜🤖 Added by blurb_it.

0230f3e

fixup! pdb: do_debug: handle SyntaxError

77991db

blueyed commented Feb 7, 2019

View reviewed changes

eamanu reviewed Feb 8, 2019

View reviewed changes

fixup! fixup! pdb: do_debug: handle SyntaxError

256699b

blueyed mentioned this pull request Feb 8, 2019

[RFC] pdb.do_debug: handle any exceptions #6506

Closed

eamanu approved these changes Feb 15, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Feb 15, 2019

zware changed the title ~~bpo-35931: pdb: do_debug: handle SyntaxError~~ bpo-35931: Gracefully handle SyntaxError in pdb debug command Feb 15, 2019

zware added 🤖 automerge labels Feb 15, 2019

Reword news entry

8599e61

zware approved these changes Feb 15, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Feb 15, 2019

miss-islington merged commit 4327705 into python:master Feb 15, 2019

bedevere-bot removed the awaiting merge label Feb 15, 2019

bedevere-bot removed the needs backport to 3.7 label Feb 15, 2019

blueyed deleted the do_debug-handle-SyntaxError branch February 15, 2019 21:07

blueyed added a commit to pdbpp/pdbpp that referenced this pull request Feb 15, 2019

do_debug: handle SyntaxError

9747174

NOTE: will be fixed in Python 3.7.3 itself (python/cpython#11782).

blueyed mentioned this pull request Feb 15, 2019

do_debug: handle SyntaxError pdbpp/pdbpp#139

Merged

blueyed added a commit to pdbpp/pdbpp that referenced this pull request Feb 16, 2019

do_debug: handle SyntaxError (#139)

561c743

NOTE: will be fixed in Python 3.7.3 itself (python/cpython#11782).

blueyed added a commit to blueyed/rebased-pdbpp that referenced this pull request May 25, 2019

do_debug: handle SyntaxError (#139)

a762e50

NOTE: will be fixed in Python 3.7.3 itself (python/cpython#11782).

		@@ -0,0 +1 @@
		pdb: handle SyntaxError with ``debug``. No newline at end of file

Uh oh!

Uh oh!

Conversation

blueyed commented Feb 7, 2019 • edited by zware Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zware left a comment

Choose a reason for hiding this comment

Uh oh!

blueyed commented Feb 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eamanu left a comment

Choose a reason for hiding this comment

Uh oh!

zware left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Feb 15, 2019

Uh oh!

miss-islington commented Feb 15, 2019

Uh oh!

bedevere-bot commented Feb 15, 2019

Uh oh!

blueyed commented Feb 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

blueyed commented Feb 7, 2019 •

edited by zware

Loading