Skip to content

gh-117649: Fix file descriptor leak in (expected) failing test case #117780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 1 commit into from
Apr 11, 2024
Merged

gh-117649: Fix file descriptor leak in (expected) failing test case #117780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-117649: Fix file descriptor leak in (expected) failing test case 
The test case is currently expected to fail in the free-threaded build.
However, it fails before it gets a chance to close the write end of
the pipe.
  • Loading branch information
@colesbury
colesbury committed Apr 11, 2024
commit 82ceef0276f5f96ae96466b554966e624eb3f827
3 changes: 3 additions & 0 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2139,6 +2139,9 @@ def check(enabled, override):
}

r, w = os.pipe()
if Py_GIL_DISABLED:
# gh-117649: The test fails before `w` is closed
self.addCleanup(os.close, w)
script = textwrap.dedent(f'''
from test.test_capi.check_config import run_singlephase_check
run_singlephase_check({override}, {w})
Expand Down