Skip to content

gh-115142: Skip test_capi.test_dict.py if _testcapi and _testlimitedcapi are not available - #117588

Merged
encukou merged 1 commit into
python:mainfrom
Eclips4:issue-115142-test-dict
Apr 10, 2024
Merged

gh-115142: Skip test_capi.test_dict.py if _testcapi and _testlimitedcapi are not available#117588
encukou merged 1 commit into
python:mainfrom
Eclips4:issue-115142-test-dict

Conversation

@Eclips4

@Eclips4 Eclips4 commented Apr 6, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@Eclips4
Eclips4 requested a review from serhiy-storchaka April 6, 2024 19:26
@bedevere-app bedevere-app Bot mentioned this pull request Apr 6, 2024
Open
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Apr 6, 2024
@Eclips4 Eclips4 added the needs backport to 3.12 only security fixes label Apr 6, 2024
@encukou
encukou merged commit dfcae43 into python:main Apr 10, 2024
@miss-islington-app

miss-islington-app Bot commented Apr 10, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Apr 10, 2024

Copy link
Copy Markdown

Sorry, @Eclips4 and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker dfcae4379f2cc4d352a180f9fef2381570aa9bcb 3.12

@Eclips4 Eclips4 mentioned this pull request Apr 10, 2024
Merged
@bedevere-app

bedevere-app Bot commented Apr 10, 2024

Copy link
Copy Markdown

GH-117718 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 10, 2024
@Eclips4
Eclips4 deleted the issue-115142-test-dict branch April 10, 2024 17:11
Eclips4 added a commit to Eclips4/cpython that referenced this pull request Apr 10, 2024
@Eclips4
[3.12] pythongh-115142: Skip test_capi.test_dict.py if ``_testcap…
229f759 
…i`` and ``_testlimitedcapi`` are not available (pythonGH-117588)

(cherry picked from commit dfcae43)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
pythongh-115142: Skip test_dict if _testcapi and _testlimitedcapi is not available
encukou pushed a commit that referenced this pull request Apr 11, 2024
@Eclips4
[3.12] gh-115142: Skip test_capi.test_dict.py if _testcapi is not…
8c1c71e 
… available (GH-117588) (GH-117718)

(cherry picked from commit dfcae43)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Eclips4 @diegorusso
pythongh-115142: Skip test_capi.test_dict.py if _testcapi and…
801f35d 
… ``_testlimitedcapi`` are not available (pythonGH-117588)

pythongh-115142: Skip test_dict if _testcapi and _testlimitedcapi is not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@encukou encukou

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eclips4 @serhiy-storchaka @encukou