Skip to content

gh-76785: Handle Legacy Interpreters Properly #117490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 19 commits into from
Apr 11, 2024
Merged

gh-76785: Handle Legacy Interpreters Properly #117490

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5b68f4d
Identify unmanaged interpreters.
ericsnowcurrently Mar 22, 2024
1811e50
Implement using a hashtable.
ericsnowcurrently Mar 25, 2024
05a3923
Call drop_owned() after Py_EndInterpreter(), not before.
ericsnowcurrently Apr 2, 2024
6f7c83d
Use a linked list.
ericsnowcurrently Mar 25, 2024
3a60142
Add restrictions.
ericsnowcurrently Mar 25, 2024
98fc876
Hide unmanaged interpreters.
ericsnowcurrently Mar 25, 2024
c2629b7
Use Interpreter for unmanaged interpreters.
ericsnowcurrently Mar 25, 2024
f1e2461
Fix other tests.
ericsnowcurrently Apr 9, 2024
55a1c31
Default to require_owned=False.
ericsnowcurrently Apr 9, 2024
f73b6f3
Interpreter.owned -> Interpreter.whence
ericsnowcurrently Apr 10, 2024
7e6432c
require_owned -> restrict
ericsnowcurrently Apr 10, 2024
19b68eb
Add PyInterpreterState._whence.
ericsnowcurrently Apr 10, 2024
d713ecf
Drop the module's global state.
ericsnowcurrently Apr 10, 2024
fe362d1
Drop a duplicate module func def.
ericsnowcurrently Apr 10, 2024
cd7d5ee
Require the interpreter to be ready for most operations.
ericsnowcurrently Apr 10, 2024
4f92794
Do not expose not-ready interpreters in the high-level module.
ericsnowcurrently Apr 10, 2024
e38f141
Fix destroying a not-ready interpreter.
ericsnowcurrently Apr 10, 2024
2274d6e
Hide a variable on non-debug builds.
ericsnowcurrently Apr 11, 2024
c796cfa
Merge branch 'main' into hide-legacy-subinterpreters
ericsnowcurrently Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Call drop_owned() after Py_EndInterpreter(), not before.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Apr 11, 2024
commit 05a39235771d62f656824d4c2a059993ffde9747
8 changes: 4 additions & 4 deletions Modules/_xxsubinterpretersmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,9 +550,8 @@ add_owned(owned_ids *owned, PyInterpreterState *interp)
}

static void
drop_owned(owned_ids *owned, PyInterpreterState *interp)
drop_owned(owned_ids *owned, int64_t interpid)
{
int64_t id = PyInterpreterState_GetID(interp);
#if sizeof(int64_t) <= sizeof(Py_uhash_t)
_Py_hashtable_steal(owned_ids, (const void *)id);
#else
Expand Down Expand Up @@ -758,6 +757,7 @@ interp_destroy(PyObject *self, PyObject *args, PyObject *kwds)
if (interp == NULL) {
return NULL;
}
int64_t interpid = PyInterpreterState_GetID(interp);

// Ensure we don't try to destroy the current interpreter.
PyInterpreterState *current = _get_current_interp();
Expand All @@ -778,11 +778,11 @@ interp_destroy(PyObject *self, PyObject *args, PyObject *kwds)
return NULL;
}

drop_owned(&_globals.owned, interp);

// Destroy the interpreter.
_PyXI_EndInterpreter(interp, NULL, NULL);

drop_owned(&_globals.owned, interpid);

Py_RETURN_NONE;
}

Expand Down