gh-117347: Fix test_clinic side effects - #117363
Merged
Merged
Conversation
Save/restore converters in ClinicWholeFileTest and ClinicExternalTest.
Member
Author
erlend-aasland
approved these changes
Mar 29, 2024
Contributor
|
Thanks! |
vstinner
enabled auto-merge (squash)
March 29, 2024 10:04
Eclips4
approved these changes
Mar 29, 2024
Eclips4
left a comment
Member
There was a problem hiding this comment.
I can confirm that this has fixed the problem; LGTM!
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @vstinner, I could not cleanly backport this to |
|
Sorry, @vstinner, I could not cleanly backport this to |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Mar 29, 2024
Save/restore converters in ClinicWholeFileTest and ClinicExternalTest. (cherry picked from commit 35b6c4a)
|
GH-117365 is a backport of this pull request to the 3.12 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save/restore converters in ClinicWholeFileTest and ClinicExternalTest.
test_clinicfails with the--foreverargument #117347