Skip to content

GH-70647: Deprecate strptime day of month parsing without a year present to avoid leap-year bugs #117107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 9 commits into from
Apr 3, 2024
Merged

GH-70647: Deprecate strptime day of month parsing without a year present to avoid leap-year bugs #117107

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b929e4
Deprecate strptime leap-year ambiguous MM-DD parsing.
gpshead Mar 20, 2024
b0eacf9
Fix the stacklevel and remove example from the warning message.
gpshead Mar 20, 2024
5851b0b
Simplify _assertNotWarns error message, removing a typo.
gpshead Mar 20, 2024
a068dac
add a unittest for _assertNotWarns.
gpshead Mar 20, 2024
333ba57
Document the behavior deprecation.
gpshead Mar 29, 2024
b12e7e5
minor doc cleanup.
gpshead Apr 1, 2024
d4c994e
adjust example code comments.
gpshead Apr 1, 2024
92e30b8
Fix doctest
encukou Apr 2, 2024
f1bd314
Use skip_file_prefixes for the warning
encukou Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the stacklevel and remove example from the warning message.
  • Loading branch information
@gpshead
gpshead committed Mar 20, 2024
commit b0eacf9db3bf7e6cb1a1d7e4db1068f3402c967e
6 changes: 2 additions & 4 deletions Lib/_strptime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,12 +270,10 @@ def pattern(self, format):
Parsing dates involving a day of month without a year specified is ambiguious
and fails to parse leap day. The default behavior will change in Python 3.15
to either always raise an exception or to use a different default year (TBD).
To avoid trouble, add a specific year to the input & format. For example:
strptime(f"{mm_dd},{datetime.now().year}", "%m-%d,%y")
To avoid trouble, add a specific year to the input & format.
See https://github.com/python/cpython/issues/70647.""",
DeprecationWarning,
# -> .compile -> {time,datetime}.strptime -> User
stacklevel=3)
stacklevel=5)
Copy link
Copy Markdown
Member

@encukou encukou Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 5 looks fragile, but I don't see a good way around it, short of teaching warnings new tricks.
Hopefully this code won't get refactored in the next few years.

Copy link
Copy Markdown
Member

@encukou encukou Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow, nice job with the time machine :)

Suggested change
stacklevel=5)
skip_file_prefixes=(os.path.dirname(__file__),))

Looks like this would be the first use of skip_file_prefixes in the stdlib.

return "%s%s" % (processed_format, format)

def compile(self, format):
Expand Down