Skip to content

gh-113964: Restore the ability to start threads from atexit handler functions. #116982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gpshead wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-113964: Restore the ability to start threads from atexit handler functions. #116982

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
150a2d7
Restore the ability to start threads from atexit handler functions.
gpshead Mar 19, 2024
1ba58cd
Fix duplicate test method name and _thread test.
gpshead Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix duplicate test method name and _thread test.
  • Loading branch information
@gpshead
gpshead committed Mar 19, 2024
commit 1ba58cd17536c2e0da2f81ecb956757236067286
7 changes: 3 additions & 4 deletions Lib/test/test_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,18 +1161,17 @@ def test_start_new_thread_at_exit(self):
import _thread

def f():
print("should be printed")
pass

def exit_handler():
_thread.start_new_thread(f, ())

atexit.register(exit_handler)
"""
_, out, err = assert_python_ok("-c", code)
self.assertEqual(out.strip(), b'should be printed',
msg=err.decode('utf-8', errors='replace'))
self.assertEqual(err.strip(), b'')

def test_start_new_thread_at_exit(self):
def test_start_threading_thread_at_exit(self):
# gh-113964: atexit needs to be able to start threads.
code = """if 1:
import atexit
Expand Down