Skip to content

Revert "gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#110123)" #116964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colesbury wants to merge 1 commit into from
Closed

Revert "gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#110123)" #116964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "gh-110119: Temporarily skip test_cppext on --disable-gil buil… 
…ds. (#110123)"

The `test_cppext` can run now that the `wheel` package is updated.

This reverts commit 2973970.
  • Loading branch information
@colesbury
colesbury committed Mar 18, 2024
commit a74c8dae5fc4941b63bb7ac7a025796622af644f
4 changes: 0 additions & 4 deletions Lib/test/test_cppext/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
SETUP = os.path.join(os.path.dirname(__file__), 'setup.py')


# gh-110119: pip does not currently support 't' in the ABI flag use by
# --disable-gil builds. Once it does, we can remove this skip.
@unittest.skipIf(support.Py_GIL_DISABLED,
'test does not work with --disable-gil')
@support.requires_subprocess()
class TestCPPExt(unittest.TestCase):
@support.requires_resource('cpu')
Expand Down