Skip to content

gh-116647: Fix recursive child in dataclasses #116790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carljm merged 7 commits into from Mar 19, 2024
Merged

gh-116647: Fix recursive child in dataclasses #116790

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a89f4d
gh-116647: Fix recursive child in dataclasses
Mar 14, 2024
8d3e131
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 14, 2024
c7f897f
gh-116647: reverting the code
Mar 15, 2024
416fd6d
Merge branch 'main' into fix-issue-116647
Mar 18, 2024
3008255
gh-116647: fix improve efficiency
Mar 18, 2024
5bdd010
gh-116647: fix improve code style
Mar 19, 2024
127d36e
Merge branch 'main' into fix-issue-116647
Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-116647: reverting the code
  • Loading branch information
Ethan committed Mar 15, 2024
commit c7f897f2ffe3a9632c22772a3dc98699c6c7eebb
18 changes: 7 additions & 11 deletions Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,17 +1072,13 @@ def _process_class(cls, init, repr, eq, order, unsafe_hash, frozen,
if eq:
# Create __eq__ method. There's no need for a __ne__ method,
# since python will call __eq__ and negate it.
cmp_fields = (field for field in field_list if field.compare)
terms = [f'(self.{field.name},)==(other.{field.name},)' for field in cmp_fields]
field_comparisons = ' and '.join(terms) or 'True'
body = [f'if other.__class__ is self.__class__:',
f' return {field_comparisons}',
f'return NotImplemented']
func = _create_fn('__eq__',
('self', 'other'),
body,
globals=globals)
_set_new_attribute(cls, '__eq__', func)
flds = [f for f in field_list if f.compare]
self_tuple = _tuple_str('self', flds)
other_tuple = _tuple_str('other', flds)
_set_new_attribute(cls, '__eq__',
_cmp_fn('__eq__', '==',
self_tuple, other_tuple,
globals=globals))

if order:
# Create and set the ordering methods.
Expand Down