Skip to content

gh-116098: Clean up frame allocation code and remove the invalid sneaky frame test #116687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 2 commits into from
Mar 12, 2024
Merged

gh-116098: Clean up frame allocation code and remove the invalid sneaky frame test #116687

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efbb9d0
Remove the invalid sneaky frame test
gaogaotiantian Mar 12, 2024
8b9c1e1
Grammar
brandtbucher Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Grammar
  • Loading branch information
@brandtbucher
brandtbucher authored Mar 12, 2024
commit 8b9c1e134b311294870a87f45102aa3e5a60590a
2 changes: 1 addition & 1 deletion Python/frame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ _PyFrame_MakeAndSetFrameObject(_PyInterpreterFrame *frame)
// be assigned already. That path does not exist anymore. We won't call any
// Python code in this function and garbage collection will not run.
// Notice that _PyFrame_New_NoTrack() can potentially raise a MemoryError,
// but it won't allocate traceback until the frame unwind so we are safe
// but it won't allocate a traceback until the frame unwinds, so we are safe
// here.
assert(frame->frame_obj == NULL);
assert(frame->owner != FRAME_OWNED_BY_FRAME_OBJECT);
Expand Down