Skip to content

bpo-35726: Add test for QueueHandler with multiple handlers#11659

Merged
vsajip merged 1 commit into
python:masterfrom
tirkarthi:bpo35726-test
Apr 7, 2019
Merged

bpo-35726: Add test for QueueHandler with multiple handlers#11659
vsajip merged 1 commit into
python:masterfrom
tirkarthi:bpo35726-test

Conversation

@tirkarthi
Copy link
Copy Markdown
Member

@tirkarthi tirkarthi commented Jan 23, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 23, 2019
@tirkarthi
Copy link
Copy Markdown
Member Author

tirkarthi commented Jan 23, 2019

@vsajip @Zheaoli I have created a test based on my understanding of PR #11537 . Feedback welcome if there are any changes to be made.

eamanu
eamanu approved these changes Jan 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Zheaoli
Copy link
Copy Markdown
Contributor

Zheaoli commented Jan 24, 2019

@tirkarthi Nice job bro, It's seem good

@tirkarthi
Copy link
Copy Markdown
Member Author

tirkarthi commented Apr 7, 2019

Ping @vsajip

@vsajip vsajip merged commit 2dad960 into python:master Apr 7, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 7, 2019

Thanks @tirkarthi for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2019
@tirkarthi @miss-islington
bpo-35726: Add test for QueueHandler with multiple handlers (pythonGH…
914a586 
…-11659)

(cherry picked from commit 2dad960)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 7, 2019

GH-12714 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented May 2, 2019

Thanks @tirkarthi for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2019
@tirkarthi @miss-islington
bpo-35726: Add test for QueueHandler with multiple handlers (pythonGH…
9364605 
…-11659)

(cherry picked from commit 2dad960)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 2, 2019

GH-13061 is a backport of this pull request to the 3.7 branch.

ned-deily pushed a commit that referenced this pull request May 2, 2019
@miss-islington @tirkarthi @ned-deily
bpo-35726: Add test for QueueHandler with multiple handlers (GH-11659) (
3f8f64e 
GH-13061)

(cherry picked from commit 2dad960)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tirkarthi @Zheaoli @miss-islington @bedevere-bot @eamanu @vsajip @ned-deily @the-knights-who-say-ni