Skip to content

gh-116560: Add PyLong_GetSign() public function #116561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 18 commits into from
Jun 3, 2024
Merged

gh-116560: Add PyLong_GetSign() public function #116561

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
cb4af47
gh-116560: Add PyLong_Sign() public function
skirpichev Mar 10, 2024
c38819d
+ test
skirpichev Mar 10, 2024
826f537
Add what's new entry
skirpichev Mar 11, 2024
2c0b118
Change PyLong_Sign() API per review request
skirpichev Mar 11, 2024
97776b4
Update Include/cpython/longobject.h
skirpichev Mar 11, 2024
5f4eb29
Address review; test_long_sign(): check -> sign
skirpichev Mar 11, 2024
7f7b56c
Merge branch 'main' into PyLong_Sign-116560
skirpichev Apr 2, 2024
a254dd3
Merge branch 'main' into PyLong_Sign-116560
skirpichev Apr 15, 2024
38c6672
+1 // damn web editor
skirpichev Apr 15, 2024
86e470e
Merge branch 'main' into PyLong_Sign-116560
skirpichev Jun 2, 2024
da0ac2b
Update Objects/longobject.c
skirpichev Jun 2, 2024
3aec06c
Merge branch 'master' into PyLong_Sign-116560
skirpichev Jun 2, 2024
41a33b4
PyLong_Sign -> PyLong_GetSign
skirpichev Jun 2, 2024
12c6aa0
Apply suggestions from code review
skirpichev Jun 3, 2024
e02c095
address review: move news, etc; polishing
skirpichev Jun 3, 2024
89a07fe
Update Doc/c-api/long.rst
vstinner Jun 3, 2024
6b98d70
+1
skirpichev Jun 3, 2024
21eeb54
Update Lib/test/test_capi/test_long.py
skirpichev Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Lib/test/test_capi/test_long.py
  • Loading branch information
@skirpichev
skirpichev authored Jun 3, 2024
commit 21eeb54abb30afd5e1904c944d7332e9571765ef
2 changes: 1 addition & 1 deletion Lib/test/test_capi/test_long.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ def test_long_getsign(self):
self.assertRaises(TypeError, getsign, 1.0)
self.assertRaises(TypeError, getsign, Index(123))

# CRACHES(getsign)
# CRASHES getsign(NULL)


if __name__ == "__main__":
Expand Down