Skip to content

gh-112087: Make list.sort to be thread-safe for PEP 703. #116553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 3 commits into from
Mar 10, 2024
Merged

gh-112087: Make list.sort to be thread-safe for PEP 703. #116553

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a55c7d
gh-112087: Make list.sort to be threaf-safe for PEP 703.
corona10 Mar 9, 2024
d868d15
Uuse atmoic_store_tpr for self->ob_item = NULL;
corona10 Mar 10, 2024
df6fe4f
Use more atomic operations
corona10 Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use more atomic operations
  • Loading branch information
@corona10
corona10 committed Mar 10, 2024
commit df6fe4fa7ac456ac35d7927ce4bb82519162d3fa
4 changes: 2 additions & 2 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2844,8 +2844,8 @@ list_sort_impl(PyListObject *self, PyObject *keyfunc, int reverse)
final_ob_item = self->ob_item;
i = Py_SIZE(self);
Py_SET_SIZE(self, saved_ob_size);
self->ob_item = saved_ob_item;
self->allocated = saved_allocated;
FT_ATOMIC_STORE_PTR_RELEASE(self->ob_item, saved_ob_item);
FT_ATOMIC_STORE_SSIZE_RELAXED(self->allocated, saved_allocated);
if (final_ob_item != NULL) {
/* we cannot use list_clear() for this because it does not
guarantee that the list is really empty when it returns */
Expand Down