Skip to content

gh-76785: Expand How Interpreter Queues Handle Interpreter Finalization #116431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 12 commits into from
Jul 15, 2024
Merged

gh-76785: Expand How Interpreter Queues Handle Interpreter Finalization #116431

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
301d218
Expand options for when an interpreter is destroyed.
ericsnowcurrently Mar 6, 2024
cc5354d
Do not convert the unbound op between str and int.
ericsnowcurrently Mar 6, 2024
ebd4950
UNBOUND_REPLACE_DEFAULT -> UNBOUND_REPLACE
ericsnowcurrently Mar 6, 2024
594428b
Add some asserts.
ericsnowcurrently Mar 6, 2024
b13cb4c
Keep track of each item's interpreter ID.
ericsnowcurrently Mar 6, 2024
1c252bb
Merge branch 'main' into queue-interp-destroyed-placeholder
ericsnowcurrently Jul 12, 2024
be0db76
Add some extra info to the put() docstring.
ericsnowcurrently Jul 12, 2024
8dcb8ff
Clarify a comment.
ericsnowcurrently Jul 12, 2024
4053c1c
Drop an unused variable.
ericsnowcurrently Jul 12, 2024
d64d298
Fix some typos.
ericsnowcurrently Jul 12, 2024
f820c70
Fix a docstring.
ericsnowcurrently Jul 12, 2024
94f4f56
Fix list_all().
ericsnowcurrently Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some typos.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Jul 12, 2024
commit d64d298ae1d0ea4412b94ef1f5f201a7d36fcdce
4 changes: 2 additions & 2 deletions Lib/test/support/interpreters/queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def create(maxsize=0, *, syncobj=False, unbounditems=UNBOUND):
"syncobj" sets the default for Queue.put()
and Queue.put_nowait().

"unbounditems" likewise sets the default. See Queue.pop() for
"unbounditems" likewise sets the default. See Queue.put() for
supported values. The default value is UNBOUND, which replaces
the unbound item.
"""
Expand Down Expand Up @@ -206,7 +206,7 @@ def put(self, obj, timeout=None, *,
This blocks while the queue is full.

If "syncobj" is None (the default) then it uses the
queue's default, set with create_queue()..
queue's default, set with create_queue().

If "syncobj" is false then all objects are supported,
at the expense of worse performance.
Expand Down