Skip to content

[3.7] bpo-34323: Enhance IocpProactor.close() log#11565

Merged
vstinner merged 3 commits into
python:3.7from
vstinner:proactor_log37
Jan 15, 2019
Merged

[3.7] bpo-34323: Enhance IocpProactor.close() log#11565
vstinner merged 3 commits into
python:3.7from
vstinner:proactor_log37

Conversation

@vstinner

@vstinner vstinner commented Jan 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@vstinner
IocpProactor: prevent modification if closed (GH-11494)
1ad4dd3 
* _wait_for_handle(), _register() and _unregister() methods of
  IocpProactor now raise an exception if closed
* Add "closed" to IocpProactor.__repr__()
* Simplify IocpProactor.close()

(cherry picked from commit 9b07681)
@vstinner
bpo-34323: Enhance IocpProactor.close() log (GH-11555)
5d70012 
IocpProactor.close() now uses time to decide when to log: wait 1
second before the first log, then log every second. Log also the
number of seconds since close() was called.

(cherry picked from commit b1e4573)
@vstinner
bpo-11555: Enhance IocpProactor.close() log again (GH-11563)
56ac680 
Add repr(self) to the log to display the number of pending overlapped
in the log.

(cherry picked from commit b91140f)
@vstinner vstinner changed the title [3.7] bpo-11555: Enhance IocpProactor.close() log [3.7] bpo-34323: Enhance IocpProactor.close() log Jan 15, 2019
@vstinner vstinner merged commit d5a6adf into python:3.7 Jan 15, 2019
@vstinner vstinner deleted the proactor_log37 branch January 15, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot