Skip to content

gh-115543: Update py.exe to know about Python 3.13 and to install 3.12 by default #115544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 1 commit into from
Feb 19, 2024
Merged

gh-115543: Update py.exe to know about Python 3.13 and to install 3.12 by default #115544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Windows/2024-02-15-23-16-31.gh-issue-115543.otrWnw.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:ref:`launcher` can now detect Python 3.13 when installed from the Microsoft
Store, and will install Python 3.12 by default when
:envvar:`PYLAUNCHER_ALLOW_INSTALL` is set.
5 changes: 4 additions & 1 deletion PC/launcher2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1962,6 +1962,7 @@ struct AppxSearchInfo {

struct AppxSearchInfo APPX_SEARCH[] = {
// Releases made through the Store
{ L"PythonSoftwareFoundation.Python.3.13_qbz5n2kfra8p0", L"3.13", 10 },
{ L"PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0", L"3.12", 10 },
{ L"PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0", L"3.11", 10 },
{ L"PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0", L"3.10", 10 },
Expand All @@ -1971,6 +1972,7 @@ struct AppxSearchInfo APPX_SEARCH[] = {
// Side-loadable releases. Note that the publisher ID changes whenever we
// renew our code-signing certificate, so the newer ID has a higher
// priority (lower sortKey)
{ L"PythonSoftwareFoundation.Python.3.13_3847v3x7pw1km", L"3.13", 11 },
{ L"PythonSoftwareFoundation.Python.3.12_3847v3x7pw1km", L"3.12", 11 },
{ L"PythonSoftwareFoundation.Python.3.11_3847v3x7pw1km", L"3.11", 11 },
{ L"PythonSoftwareFoundation.Python.3.11_hd69rhyc2wevp", L"3.11", 12 },
Expand Down Expand Up @@ -2052,7 +2054,8 @@ struct StoreSearchInfo {


struct StoreSearchInfo STORE_SEARCH[] = {
{ L"3", /* 3.11 */ L"9NRWMJP3717K" },
{ L"3", /* 3.12 */ L"9NCVDN91XZQP" },
Copy link
Copy Markdown
Contributor

@itamaro itamaro Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of the release manager's playbook when making a 3.x.0 release?

Copy link
Copy Markdown
Member Author

@zooba zooba Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad idea, though it's in a bit of a weird spot really. The most likely way for people to get the update with the change is to install the new release, at which point they won't hit this code path (or in fact any Python 3 release, so even updating an old one).

It's possible to install the launcher separately with winget (or directly if you know the URL), which is what makes this feature at all useful, but those updates will lag anyway as we don't control them ourselves.

Plus it's all a bit of an experiment, so I kinda want to see how it goes before baking it into our formal process.

{ L"3.13", L"9PNRBTZXMB4Z" },
{ L"3.12", L"9NCVDN91XZQP" },
{ L"3.11", L"9NRWMJP3717K" },
{ L"3.10", L"9PJPW5LDXLZ5" },
Expand Down