gh-115317: Rewrite changelog filter to use vanilla JavaScript#115324
Merged
Conversation
aisk
reviewed
Feb 12, 2024
tomasr8
reviewed
Feb 12, 2024
Member
tomasr8
left a comment
There was a problem hiding this comment.
Just noticed some minor style things ;)
Comment on lines
+48
to
+49
| } | ||
| else { |
Member
There was a problem hiding this comment.
I think this is the more common formatting for blocks in js
Suggested change
| } | |
| else { | |
| } else { |
Member
Author
There was a problem hiding this comment.
Yeah, I'm going to just run Prettier on this :)
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
tomasr8
reviewed
Feb 12, 2024
Co-authored-by: Tomas R <tomas.roun8@gmail.com>
ezio-melotti
approved these changes
Feb 12, 2024
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2024
…ythonGH-115324) (cherry picked from commit 341d787) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Tomas R <tomas.roun8@gmail.com>
|
GH-115372 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2024
…ythonGH-115324) (cherry picked from commit 341d787) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Tomas R <tomas.roun8@gmail.com>
|
GH-115373 is a backport of this pull request to the 3.11 branch. |
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
…ython#115324) Co-authored-by: Tomas R <tomas.roun8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sphinx removed the jQuery library to improve performance, but the changelog filter was still using it. This PR rewrites it to use basic JavaScript.
Demo
https://cpython-previews--115324.org.readthedocs.build/en/115324/whatsnew/changelog.html