Skip to content

bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) #11521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjw296 merged 4 commits into from
May 7, 2019
Merged

bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) #11521

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe5c357
unittest.mock.mock_open() results now respects the argument of read([…
Jan 11, 2019
ee7d67a
Add test for successive reads
May 6, 2019
59b08e6
Remove code duplication
May 6, 2019
b48ed55
Update Misc/NEWS.d/next/Library/2019-01-11-17-09-15.bpo-31855.PlhfsX.rst
tirkarthi May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for successive reads
  • Loading branch information
Rémi Lapeyre committed May 6, 2019
commit ee7d67ae261d43f7065f3ef7a89857f6e9528930
5 changes: 5 additions & 0 deletions Lib/unittest/test/testmock/testwith.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,11 @@ def test_mock_open_read_with_argument(self):
some_data = 'foo\nbar\nbaz'
mock = mock_open(read_data=some_data)
self.assertEqual(mock().read(10), some_data[:10])
Comment thread
remilapeyre marked this conversation as resolved.
self.assertEqual(mock().read(10), some_data[:10])

f = mock()
self.assertEqual(f.read(10), some_data[:10])
self.assertEqual(f.read(10), some_data[10:])


def test_interleaved_reads(self):
Expand Down