Skip to content

gh-112087: Make list_repr and list_length to be thread-safe #114582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 3 commits into from
Jan 26, 2024
Merged

gh-112087: Make list_repr and list_length to be thread-safe #114582

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b8c0c7
gh-112087: Make list_repr and list_length to be thread-safe
corona10 Jan 26, 2024
7009cec
Address code review
corona10 Jan 26, 2024
4d0fe6a
nit
corona10 Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
nit
  • Loading branch information
@corona10
corona10 committed Jan 26, 2024
commit 4d0fe6a6d1bf3eff490e155a786d812dc5131ab2
6 changes: 3 additions & 3 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,11 +435,11 @@ list_repr_impl(PyListObject *v)
static PyObject *
list_repr(PyObject *self)
{
PyListObject *v = (PyListObject *)self;
PyObject *ret = NULL;
if (PyList_GET_SIZE(v) == 0) {
if (PyList_GET_SIZE(self) == 0) {
return PyUnicode_FromString("[]");
}
PyListObject *v = (PyListObject *)self;
PyObject *ret = NULL;
Py_BEGIN_CRITICAL_SECTION(v);
ret = list_repr_impl(v);
Py_END_CRITICAL_SECTION();
Expand Down