Skip to content

bpo-35649: update http client example#11441

Merged
JulienPalard merged 1 commit into
python:masterfrom
epicfaace:bpo35649
Sep 11, 2019
Merged

bpo-35649: update http client example#11441
JulienPalard merged 1 commit into
python:masterfrom
epicfaace:bpo35649

Conversation

@epicfaace
Copy link
Copy Markdown
Contributor

@epicfaace epicfaace commented Jan 6, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Jan 6, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 6, 2019
BoboTiG
BoboTiG approved these changes Jan 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@BoboTiG BoboTiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @epicfaace :)

Changes LGTM, I think it is not needed to add the NEWs entry (a core dev will correct me if wrong).

@csabella csabella requested a review from vadmium June 5, 2019 23:28
@epicfaace
Copy link
Copy Markdown
Contributor Author

epicfaace commented Aug 19, 2019

@vadmium any updates?

JulienPalard
JulienPalard requested changes Sep 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@JulienPalard JulienPalard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good place to demo the walrus operator, what about:

while chunk := r1.read(200):
    print(chunk)

Or we could apply your version to 3.7 and the walrus using one on 3.8?

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@JulienPalard JulienPalard merged commit 62cf698 into python:master Sep 11, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 11, 2019

Thanks @epicfaace for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2019

GH-15930 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@epicfaace @miss-islington
bpo-35649: update http client example (pythonGH-11441)
d12cd82 
(cherry picked from commit 62cf698)

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 11, 2019

GH-15931 is a backport of this pull request to the 3.7 branch.

@JulienPalard JulienPalard mentioned this pull request Sep 11, 2019
Merged
JulienPalard pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @epicfaace @JulienPalard
bpo-35649: update http client example (GH-11441) (GH-15930)
43fb3bb 
(cherry picked from commit 62cf698)

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
JulienPalard pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @epicfaace @JulienPalard
bpo-35649: update http client example (GH-11441) (GH-15931)
0fd8c05 
(cherry picked from commit 62cf698)

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@epicfaace @DinoV
bpo-35649: update http client example (pythonGH-11441)
e1cd0b7
@epicfaace epicfaace deleted the bpo35649 branch March 16, 2020 18:43
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@epicfaace @websurfer5
bpo-35649: update http client example (pythonGH-11441)
6bf55d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

@vadmium vadmium Awaiting requested review from vadmium

+1 more reviewer

@BoboTiG BoboTiG BoboTiG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@epicfaace @the-knights-who-say-ni @bedevere-bot @miss-islington @JulienPalard @BoboTiG