Skip to content

gh-87868: Skip some test in test_subprocess if python is configured with --enable-shared #113867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 5 commits into from
Jan 10, 2024
Merged

gh-87868: Skip some test in test_subprocess if python is configured with --enable-shared #113867

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4f22675
improve the assert for test_one_environment_variable
aisk Jan 9, 2024
a982151
Update Lib/test/test_subprocess.py
aisk Jan 9, 2024
6788414
Update Lib/test/test_subprocess.py
aisk Jan 10, 2024
9a25223
skip some test in test_subprocess when python is configured with shared
aisk Jan 10, 2024
5671246
also skip the test if AddressSanitizer is enabled
aisk Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ def test_one_environment_variable(self):
cmd = ["CMD", "/c", "SET", "fruit"]
with subprocess.Popen(cmd, stdout=subprocess.PIPE, env=newenv) as p:
Comment thread
aisk marked this conversation as resolved.
Outdated
stdout, _ = p.communicate()
Comment thread
aisk marked this conversation as resolved.
Outdated
self.assertTrue(stdout.startswith(b"fruit=orange"))
self.assertEqual(stdout.strip(), b"fruit=orange")

def test_invalid_cmd(self):
# null character in the command name
Expand Down