Skip to content

bpo-35540: Add collections.defaultdict support to dataclasses.{asdict,astuple} #11361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
remilapeyre wants to merge 2 commits into from
Closed

bpo-35540: Add collections.defaultdict support to dataclasses.{asdict,astuple} #11361

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e696e23
Add collections.defaultdict support to dataclasses.{asdict,astuple}
Dec 30, 2018
86f42a1
Fix typo in comments
asvetlov Dec 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo in comments 
Co-Authored-By: remilapeyre <remi.lapeyre@henki.fr>
  • Loading branch information
@asvetlov
asvetlov and remilapeyre authored Dec 30, 2018
commit 86f42a18fcf223cdaad578d503b1b8e10c32cbdb
4 changes: 2 additions & 2 deletions Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ def _asdict_inner(obj, dict_factory):
return type(obj)(_asdict_inner(v, dict_factory) for v in obj)
elif isinstance(obj, collections.defaultdict):
# defaultdict does not have the same constructor than dict and must be
# hendled separately
# handled separately
return type(obj)(obj.default_factory, ((_asdict_inner(k, dict_factory),
_asdict_inner(v, dict_factory))
for k, v in obj.items()))
Expand Down Expand Up @@ -1138,7 +1138,7 @@ def _astuple_inner(obj, tuple_factory):
return type(obj)(_astuple_inner(v, tuple_factory) for v in obj)
elif isinstance(obj, collections.defaultdict):
# defaultdict does not have the same constructor than dict and must be
# hendled separately
# handled separately
return type(obj)(obj.default_factory, ((_asdict_inner(k, dict_factory),
_asdict_inner(v, dict_factory))
for k, v in obj.items()))
Expand Down