bpo-35555: Create function to update IDLE menu item state#11343
Merged
terryjreedy merged 1 commit intopython:masterfrom Dec 28, 2018
Merged
bpo-35555: Create function to update IDLE menu item state#11343terryjreedy merged 1 commit intopython:masterfrom
terryjreedy merged 1 commit intopython:masterfrom
Conversation
* Instead of updating menu state directly, create function to update the state. * Change outwin to call function instead of updating menu directly.
eamanu
approved these changes
Dec 28, 2018
Contributor
eamanu
left a comment
There was a problem hiding this comment.
Seem a good improve on the code.
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11344 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 28, 2018
This will be needed for other menu items. Change outwin to call the function instead of updating the menu item directly. (cherry picked from commit 804a5d9) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Dec 28, 2018
This will be needed for other menu items. Change outwin to call the function instead of updating the menu item directly. (cherry picked from commit 804a5d9) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35555