bpo-30067: Fix misplaced positional argument in OS X support library#1134
Conversation
|
@JackMc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ned-deily, @vadmium and @ezio-melotti to be potential reviewers. |
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
Hi all, I have signed my CLA and contributed to CPython in the past. Confused why the bot is saying otherwise. |
|
I have resigned the CLA, hopefully that sorts it out. |
|
@JackMc once CLA is signed, you need to link your GitHub account to the account you have at bugs.python.org. please see https://cpython-devguide.readthedocs.io/pullrequest.html#licensing for more details. |
|
My apologies, didn't see that step. Linked & CLA signed! |
|
I definitely can backport it. I'll make more PRs for the backports! |
This pull request fixes the issue reported in issue number 30067 in the CPython bug tracker.
The issue is that a positional argument to the
re.subfunction which is meant to be an integer representing the maximum number of matches for replacement is actually passed the integer flag valuere.ASCIIupon further inspection, it is clear that the intention was to pass this in as a value for theflagsargument tore.sub.