Skip to content

gh-111178: Avoid calling functions from incompatible pointer types in _tkinter.c #112893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 6 commits into from
Jan 2, 2024
Merged

gh-111178: Avoid calling functions from incompatible pointer types in _tkinter.c #112893

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5bd621
Make functions compatible with Tcl_EventProc where needed
chrstphrchvz Dec 9, 2023
cb062e3
Make PyTclObject_string() compatible with getter
chrstphrchvz Dec 9, 2023
c309917
Make get_typename() compatible with getter
chrstphrchvz Dec 9, 2023
98c082d
Make PyTclObject_repr() compatible with reprfunc
chrstphrchvz Dec 9, 2023
352876b
Make PyTclObject_str() compatible with reprfunc
chrstphrchvz Dec 9, 2023
001b4cf
Make PyTclObject_dealloc() compatible with destructor
chrstphrchvz Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make PyTclObject_dealloc() compatible with destructor
  • Loading branch information
@chrstphrchvz
chrstphrchvz authored Dec 9, 2023
commit 001b4cf28ed3be88d2b6be59a42c5e440dba4e76
5 changes: 3 additions & 2 deletions Modules/_tkinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,9 @@ newPyTclObject(Tcl_Obj *arg)
}

static void
PyTclObject_dealloc(PyTclObject *self)
PyTclObject_dealloc(PyObject *_self)
{
PyTclObject *self = (PyTclObject *)_self;
PyObject *tp = (PyObject *) Py_TYPE(self);
Tcl_DecrRefCount(self->value);
Py_XDECREF(self->string);
Expand Down Expand Up @@ -827,7 +828,7 @@ static PyGetSetDef PyTclObject_getsetlist[] = {
};

static PyType_Slot PyTclObject_Type_slots[] = {
{Py_tp_dealloc, (destructor)PyTclObject_dealloc},
{Py_tp_dealloc, PyTclObject_dealloc},
{Py_tp_repr, PyTclObject_repr},
{Py_tp_str, PyTclObject_str},
{Py_tp_getattro, PyObject_GenericGetAttr},
Expand Down