Skip to content

[3.11] gh-79871: IDLE-Fix test_debugger bug and buildbot failures (GH-112258) #112260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 1 commit into from
Nov 19, 2023
+7 −5
Merged

[3.11] gh-79871: IDLE-Fix test_debugger bug and buildbot failures (GH-112258) #112260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
IDLE: Fix test_debugger bug and buildbot failures (GH-112258) 
Missing "requires('gui')" causes Tk() to fail when no gui.
This caused CI Hypothesis test to fail, but I did not understand
the its error message. Then buildbots failed.

IdbTest failed on draft Bdb replacement because so different.
Simplified version works on old and new.
(cherry picked from commit 14fd86a)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
  • Loading branch information
@terryjreedy @miss-islington
terryjreedy authored and miss-islington committed Nov 19, 2023
commit fefc0c8ae5710d445e8415f9106e710ad6bb5d6e
12 changes: 7 additions & 5 deletions Lib/idlelib/idle_test/test_debugger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
"Test debugger, coverage 19%"
"""Test debugger, coverage 66%

Try to make tests pass with draft bdbx, which may replace bdb in 3.13+.
"""

from idlelib import debugger
from collections import namedtuple
Expand Down Expand Up @@ -44,10 +47,8 @@ def setUpClass(cls):
cls.msg = 'file.py:2: <module>()'

def test_init(self):
# Test that Idb.__init_ calls Bdb.__init__.
idb = debugger.Idb(None)
self.assertIsNone(idb.gui)
self.assertTrue(hasattr(idb, 'breaks'))
self.assertIs(self.idb.gui, self.gui)
# Won't test super call since two Bdbs are very different.

def test_user_line(self):
# Test that .user_line() creates a string message for a frame.
Expand Down Expand Up @@ -279,6 +280,7 @@ class NameSpaceTest(unittest.TestCase):

@classmethod
def setUpClass(cls):
requires('gui')
cls.root = Tk()
cls.root.withdraw()

Expand Down