Skip to content

gh-101178: refactor base64.b85encode to be memory friendly #112248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
romuald wants to merge 7 commits into from
Closed

gh-101178: refactor base64.b85encode to be memory friendly #112248

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
84e20ea
gh-101178: C implementation of base64._a85encode
romuald Feb 16, 2025
74fc245
Add possible regression test in test_base64
romuald Feb 16, 2025
60a3ae6
Review changes Modules/binascii.c
romuald Feb 16, 2025
aaa09e1
Review fixes: update algorithm
romuald Feb 16, 2025
cb46a5d
Further plagiate git's implementation
romuald Feb 17, 2025
c88450b
Rename b2a_base85 as private for now
romuald Feb 17, 2025
2fc892c
Credit to git's implementation and more comments
romuald Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Further plagiate git's implementation 
Since j is not unsigned anymore we can reverse the table lookup loop
  • Loading branch information
@romuald
romuald committed Feb 17, 2025
commit cb46a5db57abd8b12d790f454e07dbf1d4a244c5
4 changes: 2 additions & 2 deletions Modules/binascii.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1308,8 +1308,8 @@ binascii_b2a_base85_impl(PyObject *module, Py_buffer *data, Py_buffer *chars,
*ascii_data++ = 'y';
}
else {
for (int j = 0; j < 5 ; j++) {
ascii_data[4 - j] = table[value % 85];
for (int j = 4; j >= 0; j--) {
ascii_data[j] = table[value % 85];
value /= 85;
}
ascii_data += 5;
Expand Down