Skip to content

gh-111942: Fix SystemError in the TextIOWrapper constructor #112061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Nov 14, 2023
Merged

gh-111942: Fix SystemError in the TextIOWrapper constructor #112061

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a85bf3
gh-111942: Fix SystemError in the TextIOWrapper constructor
serhiy-storchaka Nov 14, 2023
f290520
Update Modules/_io/textio.c
vstinner Nov 14, 2023
43b222c
Enable test on embedded null in errors on _io test
vstinner Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Enable test on embedded null in errors on _io test
  • Loading branch information
@vstinner
vstinner committed Nov 14, 2023
commit 43b222c9757f8776c0c2f1906ade4090ec353381
4 changes: 1 addition & 3 deletions Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2725,9 +2725,7 @@ def test_constructor(self):
if support.Py_DEBUG or sys.flags.dev_mode or self.is_C:
with self.assertRaises(UnicodeEncodeError):
t.__init__(b, encoding="utf-8", errors='\udcfe')
if support.Py_DEBUG or sys.flags.dev_mode:
# TODO: If encoded to UTF-8, should also be checked for
# embedded null characters.
if support.Py_DEBUG or sys.flags.dev_mode or self.is_C:
with self.assertRaises(ValueError):
t.__init__(b, encoding="utf-8", errors='replace\0')
with self.assertRaises(TypeError):
Expand Down