gh-112014: Extend memoryview to support formats with explicit endian prefix - #112013
Closed
rianhunter wants to merge 3 commits into
Closed
gh-112014: Extend memoryview to support formats with explicit endian prefix#112013rianhunter wants to merge 3 commits into
rianhunter wants to merge 3 commits into
Conversation
Previously the memoryview object supported the native endian format prefix '@'. It would fail when passed the explicit endian format prefixes '<' (little endian) or '>' (big endian) even when it matched the endianness of the running platform. This affects ctypes code like this: ``` import ctypes ArrayType = (ctypes.c_ubyte * 10) a = ArrayType() b = memoryview(a) b[0] = 1 # this used to throw an exception ``` The fix is to detect when the format prefix used is the endianness of the running platform and then treat it equivalently to the '@' prefix.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
Author
|
This PR is incorrect, the '@' format can never be replaced with '<' or '>' since the former has a native size and alignment while the latter have standard size and no alignment. I will close and find another solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the memoryview object supported the native endian format prefix '@'. It would fail when passed the explicit endian format prefixes '<' (little endian) or '>' (big endian) even when it matched the endianness of the running platform. This affects ctypes code like this:
The fix is to detect when the format prefix used is the endianness of the running platform and then treat it equivalently to the '@' prefix.
Fixes #112014