Skip to content

gh-109538: Catch closed loop runtime error and issue warning #111983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 6 commits into from
Nov 15, 2023
Merged

gh-109538: Catch closed loop runtime error and issue warning #111983

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
354780a
gh-109538: Catch closed loop runtime error and issue warning
dpr-0 Nov 11, 2023
0a1c4ef
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 11, 2023
7461e4e
Update Misc/NEWS.d/next/Library/2023-11-11-16-42-48.gh-issue-109538.c…
dpr-0 Nov 12, 2023
54106eb
use checking condition instead of try catch
dpr-0 Nov 14, 2023
b088f82
Add test
dpr-0 Nov 14, 2023
5eb3fa1
Make test more clear
dpr-0 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Lib/asyncio/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,9 +406,12 @@ async def start_tls(self, sslcontext, *,

def __del__(self, warnings=warnings):
if not self._transport.is_closing():
self.close()
warnings.warn(f"unclosed {self!r}", ResourceWarning)

try:
self.close()
except RuntimeError:
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching all RuntimeErrors always feels scary -- it could mark other, more serious bugs. How about only issuing the new warning if self._loop.is_closed()?

warnings.warn("loop is closed", ResourceWarning)
else:
warnings.warn(f"unclosed {self!r}", ResourceWarning)

class StreamReader:

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-11-11-16-42-48.gh-issue-109538.cMG5ux.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Issue warning message instead of having :class:`RuntimeError` be displayed when event loop has already been closed at :meth:`StreamWriter.__del__`.