Skip to content

gh-111942: Fix crashes in TextIOWrapper.reconfigure() #111976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
Nov 14, 2023
Merged

gh-111942: Fix crashes in TextIOWrapper.reconfigure() #111976

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d8e144
gh-111942: Fix crashes in TextIOWrapper.reconfigure()
serhiy-storchaka Nov 10, 2023
1beb787
Some checks are only in debug mode.
serhiy-storchaka Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Some checks are only in debug mode.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Nov 11, 2023
commit 1beb7874babf534d74da702e6a3e92f509714bdb
12 changes: 8 additions & 4 deletions Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2722,10 +2722,14 @@ def test_constructor(self):
t.__init__(b, encoding='utf-8\0')
with self.assertRaises(invalid_type):
t.__init__(b, encoding="utf-8", errors=42)
with self.assertRaises(UnicodeEncodeError):
t.__init__(b, encoding="utf-8", errors='\udcfe')
with self.assertRaises(ValueError):
t.__init__(b, encoding="utf-8", errors='replace\0')
if support.Py_DEBUG or sys.flags.dev_mode or self.is_C:
with self.assertRaises(UnicodeEncodeError):
t.__init__(b, encoding="utf-8", errors='\udcfe')
if support.Py_DEBUG or sys.flags.dev_mode:
# TODO: If encoded to UTF-8, should also be checked for
# embedded null characters.
with self.assertRaises(ValueError):
t.__init__(b, encoding="utf-8", errors='replace\0')
with self.assertRaises(TypeError):
t.__init__(b, encoding="utf-8", newline=42)
with self.assertRaises(ValueError):
Expand Down