Skip to content

gh-111786: Turn off optimize for speed for _PyEval_EvalFrameDefault on MSVC #111794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 8 commits into from
Nov 9, 2023
Merged

gh-111786: Turn off optimize for speed for _PyEval_EvalFrameDefault on MSVC #111794

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89b98fe
Turn off optimize
mdboom Nov 6, 2023
f87df62
Fix pragmas
mdboom Nov 6, 2023
54d99b8
Disable "t"
mdboom Nov 6, 2023
b393cd1
Turn off s
mdboom Nov 6, 2023
eadfe93
gh-111786: Do pragmas only in MSC block
mdboom Nov 6, 2023
81f7c23
Only disable the optimization when doing a PGO build
mdboom Nov 8, 2023
009e3b1
No need to pass an extra flag from the batch file
mdboom Nov 8, 2023
fb29089
Fix condition
mdboom Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pragmas
  • Loading branch information
@mdboom
mdboom committed Nov 6, 2023
commit f87df622d9e4d11a8315f171a7dbf13312c895ff
3 changes: 2 additions & 1 deletion Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ extern const struct _PyCode_DEF(8) _Py_InitCleanup;
* so consume 3 units of C stack */
#define PY_EVAL_C_STACK_UNITS 2

#pragma optimize(off)
#pragma optimize("", off)
PyObject* _Py_HOT_FUNCTION
_PyEval_EvalFrameDefault(PyThreadState *tstate, _PyInterpreterFrame *frame, int throwflag)
{
Expand Down Expand Up @@ -1082,6 +1082,7 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, _PyInterpreterFrame *frame, int
#elif defined(_MSC_VER) /* MS_WINDOWS */
# pragma warning(pop)
#endif
#pragma optimize("", on)

static void
format_missing(PyThreadState *tstate, const char *kind,
Expand Down