Skip to content

gh-94438: Add additional cases to mark_stacks with tests #111237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 8 commits into from
Oct 24, 2023
Merged

gh-94438: Add additional cases to mark_stacks with tests #111237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cbde4e9
Adds test case for JUMP_IS_NONE
savannahostrowski Oct 22, 2023
eb224c4
Add tests
savannahostrowski Oct 22, 2023
c2b4538
Appease linter
savannahostrowski Oct 23, 2023
40b2ca8
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 23, 2023
2b198b8
Update tests for line numbers and blurb it for backticks
Oct 23, 2023
33fd711
Update tests
savannahostrowski Oct 23, 2023
0143197
Update Lib/test/test_sys_settrace.py
Oct 23, 2023
80e1ba4
Add myself to ACKS
savannahostrowski Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests for line numbers and blurb it for backticks
  • Loading branch information
Savannah Ostrowski
Savannah Ostrowski committed Oct 23, 2023
commit 2b198b8abbd4b1b1ee2e33b535ba453a3b7ede8c
22 changes: 11 additions & 11 deletions Lib/test/test_sys_settrace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2064,22 +2064,22 @@ def test_jump_simple_backwards(output):
output.append(1)
output.append(2)

@jump_test(1, 4, [2])
@jump_test(1, 4, [5])
def test_jump_is_none_forwards(output):
x = None
if x is None:
output.append(1)
output.append(3)
else:
output.append(2)
output.append(5)

@jump_test(2, 1, [1, 3])
@jump_test(6, 5 [3, 5, 6])
Comment thread
savannahostrowski marked this conversation as resolved.
Outdated
def test_jump_is_none_backwards(output):
x = None
if x is None:
output.append(1)
output.append(3)
else:
output.append(2)
output.append(3)
output.append(5)
output.append(6)

@jump_test(1, 4, [2])
def test_jump_is_not_none_forwards(output):
Expand All @@ -2089,14 +2089,14 @@ def test_jump_is_not_none_forwards(output):
else:
output.append(2)

@jump_test(2, 1, [2, 3])
@jump_test(6, 5, [3, 5, 6])
def test_jump_is_not_none_backwards(output):
x = None
if x is not None:
output.append(1)
output.append(3)
else:
output.append(2)
output.append(3)
output.append(5)
output.append(6)

@jump_test(3, 5, [2, 5], warning=(RuntimeWarning, unbound_locals))
def test_jump_out_of_block_forwards(output):
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Core and Builtins/2023-10-23-22-11-09.gh-issue-94438.y2pITu.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Fix a regression that prevented jumping across `is None` and `is not None` when debugging. Patch by Savannah Ostrowski.
Fix a regression that prevented jumping across ``is None`` and ``is not None`` when debugging. Patch by Savannah Ostrowski.