Skip to content

bpo-35459: Use PyDict_GetItemWithError() instead of PyDict_GetItem() #11112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 6 commits into from
Feb 25, 2019
Merged

bpo-35459: Use PyDict_GetItemWithError() instead of PyDict_GetItem() #11112

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b79d33
bpo-35459: Use PyDict_GetItemWithError() instead of PyDict_GetItem().
serhiy-storchaka Dec 9, 2018
b2f44b7
Address review comments.
serhiy-storchaka Dec 13, 2018
41f2ec3
Merge branch 'master' into pydict-getitem
serhiy-storchaka Dec 13, 2018
15046cb
Merge branch 'master' into pydict-getitem
serhiy-storchaka Dec 15, 2018
bce5923
Merge branch 'master' into pydict-getitem
serhiy-storchaka Jan 19, 2019
fe7a98f
Merge branch 'master' into pydict-getitem
serhiy-storchaka Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into pydict-getitem
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Feb 14, 2019
commit fe7a98f9fd806c95a0a120b00a375a19269355dc
2 changes: 1 addition & 1 deletion Python/symtable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ symtable_add_def_helper(struct symtable *st, PyObject *name, int flag, struct _s

if (!mangled)
return 0;
dict = st->st_cur->ste_symbols;
dict = ste->ste_symbols;
if ((o = PyDict_GetItemWithError(dict, mangled))) {
val = PyLong_AS_LONG(o);
if ((flag & DEF_PARAM) && (val & DEF_PARAM)) {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.